New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vagrant boxes for easier testing on multiple platforms #2079

Merged
merged 3 commits into from Feb 11, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Feb 11, 2019

Proposed changes

Some vagrant boxes for ubuntu, debian and centos to easily test our scripts and core on multiple platforms.

Resolves #1908

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 11, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot ArkEcosystemBot requested review from air1one and supaiku0 Feb 11, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #2079 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2079   +/-   ##
========================================
  Coverage    78.48%   78.48%           
========================================
  Files          331      331           
  Lines         7714     7714           
  Branches      1084     1083    -1     
========================================
  Hits          6054     6054           
  Misses        1629     1629           
  Partials        31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a09340...15bd7bb. Read the comment docs.

@faustbrian faustbrian merged commit dfd478c into develop Feb 11, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the vagrant branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment