Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace lodash.sortBy/orderBy with faster implementations #2106

Merged
merged 4 commits into from Feb 17, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Add a few functions of https://github.com/ArkEcosystem/utils, more will be added later on.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Feb 16, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 16, 2019 07:20
@ghost
Copy link

ghost commented Feb 16, 2019

@faustbrian The ci/circleci: test-node11-2 job is failing as of 12be124dc694cbd91e0d4b9ede883eb22c4f0f6a. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io
Copy link

codecov-io commented Feb 16, 2019

Codecov Report

Merging #2106 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2106      +/-   ##
===========================================
+ Coverage    78.92%   78.92%   +<.01%     
===========================================
  Files          330      330              
  Lines         7972     7973       +1     
  Branches      1123     1138      +15     
===========================================
+ Hits          6292     6293       +1     
  Misses        1648     1648              
  Partials        32       32
Impacted Files Coverage Δ
...e-jest-matchers/src/blockchain/execute-on-entry.ts 75% <ø> (ø) ⬆️
packages/core-jest-matchers/src/api/block.ts 100% <100%> (ø) ⬆️
packages/core-jest-matchers/src/api/peer.ts 100% <100%> (ø) ⬆️
...kages/core-jest-matchers/src/models/transaction.ts 100% <100%> (ø) ⬆️
packages/core-database/src/repositories/wallets.ts 100% <100%> (ø) ⬆️
packages/core-jest-matchers/src/models/delegate.ts 100% <100%> (ø) ⬆️
...ckages/core-database/src/repositories/delegates.ts 68.29% <100%> (+0.79%) ⬆️
packages/core-jest-matchers/src/api/transaction.ts 100% <100%> (ø) ⬆️
packages/core-jest-matchers/src/models/wallet.ts 100% <100%> (ø) ⬆️
...kages/core-api/src/versions/2/delegates/methods.ts 74.46% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b0fa4...afd838d. Read the comment docs.

@faustbrian faustbrian merged commit b5f03f7 into develop Feb 17, 2019
@ghost ghost deleted the 2.2/utils branch February 17, 2019 04:32
@ghost ghost removed the Status: Needs Review label Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants