Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-tester-cli): add the ability to send multiple waves #2191

Merged
merged 8 commits into from Mar 3, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 2, 2019

Proposed changes

Adds the ability to perform N runs for the given command,defaults to 1.

Fiddled this together on mobile, will test and finish it on monday.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian added some commits Mar 2, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Mar 2, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 2, 2019

A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 2, 2019

The ci/circleci: test-node10-1 job is failing as of bfba095060712fe7aeba6bf7040c62403a11aac1. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Mar 2, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #2191 into 2.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3    #2191   +/-   ##
=======================================
  Coverage   78.09%   78.09%           
=======================================
  Files         320      320           
  Lines        8386     8386           
  Branches     1115     1115           
=======================================
  Hits         6549     6549           
  Misses       1802     1802           
  Partials       35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317e86e...f4bd44e. Read the comment docs.

@faustbrian faustbrian merged commit 8a95e95 into 2.3 Mar 3, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the tester/flood-waves branch Mar 3, 2019

vasild added a commit that referenced this pull request Mar 4, 2019

Merge remote-tracking branch 'ArkEcosystem/core/2.3' into blockid
* ArkEcosystem/core/2.3:
  feat(core): add support for forced updates (#2190)
  feat(core): add support for reinstalling the current version (#2192)
  feat(core-tester-cli): add the ability to send multiple waves (#2191)
  feat(core-tester-cli): test the vendor field (#2189)
  refactor: move transaction logic out of crypto (#2188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.