Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove integration setup & tests from unit tests #2194

Merged
merged 35 commits into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 3, 2019

Proposed changes

Continuation of #1964

  • Removes the setup of a full node from all unit tests (only integration tests run a node now)
  • Mock methods and properties that are now missing without the container being available
  • Moves some tests from unit into integration

To-Do

  • core-blockchain
  • core-database
  • core-database-postgres
  • core-p2p
  • core-transaction-pool
  • Run unit tests in parallel
  • Add tests command for unit and integration tests

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 4, 2019

The ci/circleci: test-node10-0 job is failing as of f1ce061dbc64bea2e82245b81d9f0fb3a07e0e69. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian changed the base branch from 2.3 to develop Mar 4, 2019

@faustbrian faustbrian referenced this pull request Mar 6, 2019

Merged

refactor: replace axios with got #2203

3 of 3 tasks complete
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #2194 into develop will decrease coverage by 0.2%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2194      +/-   ##
===========================================
- Coverage    77.48%   77.28%   -0.21%     
===========================================
  Files          317      317              
  Lines         8266     8267       +1     
  Branches      1091     1130      +39     
===========================================
- Hits          6405     6389      -16     
- Misses        1827     1846      +19     
+ Partials        34       32       -2
Impacted Files Coverage Δ
packages/core-p2p/src/monitor.ts 59.62% <47.61%> (+0.91%) ⬆️
packages/core-p2p/src/court/guard.ts 78.12% <83.33%> (ø) ⬆️
packages/core-transaction-pool/src/connection.ts 97.89% <91.66%> (ø) ⬆️
...s/core-transaction-pool/src/dynamic-fee/matcher.ts 76.92% <0%> (-17.95%) ⬇️
packages/core-blockchain/src/blockchain.ts 91.12% <0%> (-6.51%) ⬇️
...s/core-transaction-pool/src/pool-wallet-manager.ts 97.22% <0%> (-2.78%) ⬇️
packages/core-p2p/src/peer-verifier.ts 84.24% <0%> (-1.37%) ⬇️
packages/core-transaction-pool/src/mem.ts 99.09% <0%> (-0.91%) ⬇️
packages/core-p2p/src/utils/restore-peers.ts 88.88% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477db4c...6ce8f2d. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review Mar 8, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Mar 8, 2019

@faustbrian faustbrian merged commit 0479d01 into develop Mar 8, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the test/unit branch Mar 8, 2019

vasild added a commit that referenced this pull request Mar 11, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  fix(core-tester-cli): Fix the description of debug:serialize
  test: remove integration setup & tests from unit tests (#2194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.