Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.3 into develop #2198

Merged
merged 30 commits into from Mar 4, 2019

Conversation

Projects
None yet
7 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 4, 2019

Merge 2.3 into develop

paroxysm and others added some commits Feb 20, 2019

Merge pull request #2157 from supaiku0/merge-develop
Merge branch 'develop' into 2.3
refactor: replace micromatch with nanomatch and remove heavy deps (#2165
)

* refactor: replace micromatch with the more lightweight nanomatch

* fix(core-http-utils): remove non-existent deps

* fix(core-vote-report): add vision dependency

* Update create.ts

@ArkEcosystem ArkEcosystem deleted a comment from ArkEcosystemBot Mar 4, 2019

faustbrian added some commits Mar 4, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 4, 2019

The ci/circleci: test-node11-0 job is failing as of 88ff072ccec89ba4a0b2ba1ce410e5148ce33b3f. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #2198 into develop will decrease coverage by 2.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2198      +/-   ##
==========================================
- Coverage    79.85%   77.8%   -2.06%     
==========================================
  Files          253     320      +67     
  Lines         6289    8379    +2090     
  Branches       873    1154     +281     
==========================================
+ Hits          5022    6519    +1497     
- Misses        1243    1825     +582     
- Partials        24      35      +11
Impacted Files Coverage Δ
packages/crypto/src/validation/validator.ts 0% <0%> (-100%) ⬇️
...database-postgres/src/repositories/transactions.ts 18.18% <0%> (-43.36%) ⬇️
...e-database-postgres/src/repositories/repository.ts 17.64% <0%> (-37.91%) ⬇️
...ypto/src/builder/transactions/timelock-transfer.ts 65.38% <0%> (-34.62%) ⬇️
packages/core-webhooks/src/manager.ts 0% <0%> (-34.49%) ⬇️
packages/core-api/src/repositories/blocks.ts 52.77% <0%> (-30.56%) ⬇️
.../core-database-postgres/src/repositories/blocks.ts 26.82% <0%> (-28.73%) ⬇️
...o/src/builder/transactions/delegate-resignation.ts 71.42% <0%> (-28.58%) ⬇️
packages/crypto/src/builder/transactions/ipfs.ts 72% <0%> (-28%) ⬇️
...s/crypto/src/builder/transactions/multi-payment.ts 76% <0%> (-24%) ⬇️
... and 247 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdf96d...f89ebe4. Read the comment docs.

@faustbrian faustbrian merged commit dbe205c into develop Mar 4, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@faustbrian faustbrian deleted the 2.3 branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.