Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move transaction type specific logic into core-transactions #2201

Merged
merged 15 commits into from Mar 7, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Mar 5, 2019

Proposed changes

Moves all tx type specific logic into core-transactions. Still WIP.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 5, 2019

The ci/circleci: test-node10-2 job is failing as of fc84979a6b8623d59e9cd30b282a343a5dabb7f8. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystem ArkEcosystem deleted a comment from ArkEcosystemBot Mar 5, 2019

@faustbrian faustbrian changed the title refactor: move tx type logic refactor: move transaction type specific logic into core-transactions Mar 5, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #2201 into develop will decrease coverage by 8.1%.
The diff coverage is 51.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2201      +/-   ##
===========================================
- Coverage    77.82%   69.72%   -8.11%     
===========================================
  Files          321      407      +86     
  Lines         8410     9846    +1436     
  Branches      1118     1306     +188     
===========================================
+ Hits          6545     6865     +320     
- Misses        1830     2945    +1115     
- Partials        35       36       +1
Impacted Files Coverage Δ
packages/core-transactions/src/services/ipfs.ts 57.14% <0%> (ø) ⬆️
...ore-transactions/src/services/timelock-transfer.ts 57.14% <0%> (ø) ⬆️
...kages/crypto/src/transactions/types/transaction.ts 87.71% <0%> (ø) ⬆️
...es/core-transactions/src/services/multi-payment.ts 57.14% <0%> (ø) ⬆️
...-transactions/src/services/delegate-resignation.ts 50% <0%> (-7.15%) ⬇️
.../core-transactions/src/services/multi-signature.ts 27.77% <0%> (ø) ⬆️
packages/core-database/src/wallet-manager.ts 73.18% <100%> (+3.07%) ⬆️
packages/core-database/src/database-service.ts 30.7% <100%> (-1.22%) ⬇️
packages/core-transaction-pool/src/mem.ts 100% <100%> (+0.91%) ⬆️
...s/core-transaction-pool/src/pool-wallet-manager.ts 100% <100%> (ø) ⬆️
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7889947...5df52fc. Read the comment docs.

@supaiku0 supaiku0 marked this pull request as ready for review Mar 7, 2019

@supaiku0 supaiku0 requested review from faustbrian and kristjank as code owners Mar 7, 2019

@faustbrian faustbrian merged commit 9e253bd into ArkEcosystem:develop Mar 7, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

vasild added a commit that referenced this pull request Mar 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  refactor: purely rely on in-memory wallets based on transactions (#2209)
  refactor(core-blockchain): remove old fast rebuild code (#2210)
  fix: vote balance update (develop) (#2211)
  refactor: move transaction type specific logic into core-transactions (#2201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.