Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace axios with got #2203

Merged
merged 27 commits into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 6, 2019

Proposed changes

Resolves #2193

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 6, 2019

The ci/circleci: test-node11-1 job is failing as of 0f78324c93e6cd1feb5a0d7ab1ad5539ea827856. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Mar 6, 2019

@faustbrian faustbrian marked this pull request as ready for review Mar 9, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Mar 9, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 9, 2019

Codecov Report

Merging #2203 into develop will decrease coverage by 0.46%.
The diff coverage is 50.9%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2203      +/-   ##
===========================================
- Coverage    73.76%   73.29%   -0.47%     
===========================================
  Files          317      318       +1     
  Lines         7193     7213      +20     
  Branches       367      368       +1     
===========================================
- Hits          5306     5287      -19     
- Misses        1845     1884      +39     
  Partials        42       42
Impacted Files Coverage Δ
packages/core-utils/src/httpie.ts 0% <0%> (ø)
packages/core-webhooks/src/manager.ts 0% <0%> (ø) ⬆️
.../core-json-rpc/src/server/methods/blocks/latest.ts 100% <100%> (ø) ⬆️
packages/core-p2p/src/peer.ts 81.89% <100%> (-0.87%) ⬇️
packages/core-forger/src/client.ts 75.51% <100%> (-0.49%) ⬇️
packages/core-p2p/src/peer-verifier.ts 75.83% <100%> (-5%) ⬇️
...s/core-container/src/config/loaders/file-loader.ts 20.68% <33.33%> (ø) ⬆️
...kages/core-json-rpc/src/server/services/network.ts 73.8% <90.9%> (+1.71%) ⬆️
...son-rpc/src/server/methods/wallets/transactions.ts 57.14% <0%> (-42.86%) ⬇️
...-json-rpc/src/server/methods/wallets/bip38/show.ts 60% <0%> (-40%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fa7e8...9c1fb8c. Read the comment docs.

@faustbrian faustbrian referenced this pull request Mar 11, 2019

Merged

feat(core-tester-cli): add make:block command #2221

3 of 3 tasks complete

@supaiku0 supaiku0 merged commit 34d43b4 into develop Mar 12, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/got branch Mar 12, 2019

vasild added a commit that referenced this pull request Mar 12, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  fix(core-api): properly sort semver versions (#2229)
  feat(core-tester-cli): add make:block command (#2221)
  refactor: replace axios with got (#2203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.