Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-api): add active delegates endpoint #2205

Merged
merged 7 commits into from Mar 6, 2019

Conversation

Projects
None yet
3 participants
@dated
Copy link
Contributor

dated commented Mar 6, 2019

Proposed changes

Adds an additional endpoint to the delegates API to retrieve the active delegates at a certain height (use case: display rank changes in the explorer).

The getActiveAtHeight method was not being used anywhere, hence it took the liberty to modify it to the needs of this PR.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@dated dated marked this pull request as ready for review Mar 6, 2019

@dated dated requested review from kristjank and supaiku0 as code owners Mar 6, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 6, 2019

The ci/circleci: test-node11-2 job is failing as of c42f76524e8206b1e5bc3a9a14114285e7af7992. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian
Copy link
Collaborator

faustbrian left a comment

Minor change

Show resolved Hide resolved packages/core-api/src/versions/2/delegates/methods.ts Outdated

@dated dated force-pushed the dated:active-delegates branch from 30bab3c to 7760535 Mar 6, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 6, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@dated dated force-pushed the dated:active-delegates branch from 161994d to 337bd5b Mar 6, 2019

@dated

This comment has been minimized.

Copy link
Contributor Author

dated commented Mar 6, 2019

An unrelated test is currently failing @faustbrian.

FAIL  __tests__/integration/core-transaction-pool/guard.test.ts

● Transaction Guard › validate › Sign a transaction then change some fields shouldn't pass validation › should not validate when changing fields after signing - delegate registration
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 6, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 7889947 into ArkEcosystem:develop Mar 6, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 6, 2019

Your pull request has been merged and marked as tier 2. It will earn you $50 USD.

@dated dated deleted the dated:active-delegates branch Mar 6, 2019

vasild added a commit that referenced this pull request Mar 7, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  feat(core-api): add active delegates endpoint (#2205)
  fix(core-tester-cli): set crypto network for debug commands (#2204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.