Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: purely rely on in-memory wallets based on transactions #2209

Merged
merged 18 commits into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 7, 2019

Proposed changes

Removes the wallets from the database as it only served as a dump after the introduction of the integrity verification based on transactions. Since then we only use in-memory wallets.

Wallets from the database were only used during boot, not for any internal use.

To-Do

  • Resolve issues with failing tests
  • Ensure sorting of forging delegates is still the same

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 7, 2019

The ci/circleci: test-node10-2 job is failing as of 9d1ea84cba6b3c6f537f68c901b11ba31708cf42. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #2209 into develop will increase coverage by 0.33%.
The diff coverage is 15.68%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2209      +/-   ##
===========================================
+ Coverage    77.44%   77.78%   +0.33%     
===========================================
  Files          322      321       -1     
  Lines         8425     8372      -53     
  Branches      1153     1146       -7     
===========================================
- Hits          6525     6512      -13     
+ Misses        1866     1826      -40     
  Partials        34       34
Impacted Files Coverage Δ
packages/core-container/src/container.ts 52.32% <ø> (+0.6%) ⬆️
packages/core-database/src/wallet-manager.ts 76.53% <ø> (ø) ⬆️
packages/core-database/src/database-service.ts 31.4% <0%> (+0.69%) ⬆️
packages/core-blockchain/src/state-machine.ts 98.43% <100%> (-0.03%) ⬇️
.../core-database-postgres/src/postgres-connection.ts 64.07% <33.33%> (+7.41%) ⬆️
...s/core-database-postgres/src/integrity-verifier.ts 8% <7.14%> (ø)
...ckages/core-database-postgres/src/models/wallet.ts 66.66% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62aeb20...e99f1aa. Read the comment docs.

faustbrian added some commits Mar 7, 2019

@faustbrian faustbrian marked this pull request as ready for review Mar 8, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Mar 8, 2019

supaiku0 added some commits Mar 8, 2019

@supaiku0 supaiku0 merged commit 477db4c into develop Mar 8, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/wallets branch Mar 8, 2019

vasild added a commit that referenced this pull request Mar 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  refactor: purely rely on in-memory wallets based on transactions (#2209)
  refactor(core-blockchain): remove old fast rebuild code (#2210)
  fix: vote balance update (develop) (#2211)
  refactor: move transaction type specific logic into core-transactions (#2201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.