Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-blockchain): remove old fast rebuild code #2210

Merged
merged 17 commits into from Mar 8, 2019

Conversation

Projects
None yet
5 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 7, 2019

Proposed changes

Removes dead code related to the fast sync capabilities that have been dropped due to how it worked compared to a normal sync.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian changed the title refactor(core-blockchain): remove old fast rebuild cold refactor(core-blockchain): remove old fast rebuild code Mar 7, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

alexbarnsley commented Mar 7, 2019

"cold" :trollface:

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 7, 2019

The ci/circleci: test-node11-0 job is failing as of cc81c432a3cdfbeeec742790dcb9c22c6085f1fd. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #2210 into develop will decrease coverage by 0.3%.
The diff coverage is 86.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2210      +/-   ##
===========================================
- Coverage    77.44%   77.14%   -0.31%     
===========================================
  Files          322      318       -4     
  Lines         8425     8318     -107     
  Branches      1153     1097      -56     
===========================================
- Hits          6525     6417     -108     
- Misses        1866     1867       +1     
  Partials        34       34
Impacted Files Coverage Δ
packages/core-blockchain/src/state-storage.ts 100% <ø> (ø) ⬆️
...ackages/core-blockchain/src/machines/blockchain.ts 100% <ø> (ø) ⬆️
...kages/core-blockchain/src/machines/actions/fork.ts 100% <ø> (ø) ⬆️
...kchain/src/processor/handlers/unchained-handler.ts 91.3% <100%> (ø) ⬆️
packages/core-blockchain/src/state-machine.ts 98.1% <100%> (-0.37%) ⬇️
...ckages/core-api/src/versions/2/delegates/schema.ts 100% <100%> (ø) ⬆️
packages/core-blockchain/src/blockchain.ts 97.63% <75%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62aeb20...a2746ec. Read the comment docs.

@supaiku0 supaiku0 self-requested a review Mar 8, 2019

@faustbrian faustbrian marked this pull request as ready for review Mar 8, 2019

@faustbrian faustbrian requested a review from kristjank as a code owner Mar 8, 2019

@supaiku0 supaiku0 self-requested a review Mar 8, 2019

@supaiku0 supaiku0 merged commit d00d471 into develop Mar 8, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the drop/fast-rebuild branch Mar 8, 2019

vasild added a commit that referenced this pull request Mar 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  refactor: purely rely on in-memory wallets based on transactions (#2209)
  refactor(core-blockchain): remove old fast rebuild code (#2210)
  fix: vote balance update (develop) (#2211)
  refactor: move transaction type specific logic into core-transactions (#2201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.