Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vote balance update (develop) #2211

Merged
merged 3 commits into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Mar 8, 2019

Proposed changes

Ports #2207 from 2.2 to develop.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #2211 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2211      +/-   ##
===========================================
+ Coverage    77.35%   77.42%   +0.07%     
===========================================
  Files          322      322              
  Lines         8425     8425              
  Branches      1113     1113              
===========================================
+ Hits          6517     6523       +6     
+ Misses        1873     1868       -5     
+ Partials        35       34       -1
Impacted Files Coverage Δ
packages/core-database/src/wallet-manager.ts 76.53% <100%> (+3.35%) ⬆️
...kages/core-api/src/versions/2/delegates/methods.ts 77.19% <100%> (ø) ⬆️
packages/core-transaction-pool/src/config.ts 0% <0%> (-100%) ⬇️
packages/core-blockchain/src/config.ts 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e253bd...090c1b0. Read the comment docs.

@faustbrian faustbrian merged commit 62aeb20 into ArkEcosystem:develop Mar 8, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

vasild added a commit that referenced this pull request Mar 8, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  refactor: purely rely on in-memory wallets based on transactions (#2209)
  refactor(core-blockchain): remove old fast rebuild code (#2210)
  fix: vote balance update (develop) (#2211)
  refactor: move transaction type specific logic into core-transactions (#2201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.