Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies and remove unused imports #2212

merged 9 commits into from Mar 11, 2019


None yet
4 participants
Copy link

faustbrian commented Mar 8, 2019

Proposed changes

Updates dependencies and removes a bunch of unused imports.

Types of changes

  • Other


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian added some commits Mar 8, 2019


This comment has been minimized.

Copy link

ArkEcosystemBot commented Mar 8, 2019

The ci/circleci: test-node11-2 job is failing as of d03342db1e6e81a80898e9d0a030644aafcca27f. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Mar 8, 2019

supaiku0 added some commits Mar 11, 2019


This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #2212 into develop will decrease coverage by 0.41%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2212      +/-   ##
- Coverage    74.18%   73.76%   -0.42%     
  Files          317      317              
  Lines         8273     7193    -1080     
  Branches      1132      331     -801     
- Hits          6137     5306     -831     
+ Misses        2108     1845     -263     
- Partials        28       42      +14
Impacted Files Coverage Δ
.../core-json-rpc/src/server/methods/blocks/latest.ts 100% <ø> (ø) ⬆️
packages/core-elasticsearch/src/indices/rounds.ts 0% <ø> (ø) ⬆️
packages/core-container/src/registrars/plugin.ts 74% <ø> (-6.96%) ⬇️
.../src/repositories/delegates-business-repository.ts 83.33% <ø> (-2.95%) ⬇️
...ges/core-api/src/versions/2/transactions/schema.ts 100% <ø> (ø) ⬆️
packages/core-container/src/config/network.ts 44.44% <ø> (+4.44%) ⬆️
...ackages/core-p2p/src/server/versions/1/handlers.ts 0% <ø> (ø) ⬆️ 100% <ø> (ø) ⬆️
packages/core-blockchain/src/blockchain.ts 90.84% <ø> (-0.33%) ⬇️
packages/core-transaction-pool/src/connection.ts 98.11% <ø> (+0.21%) ⬆️
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee8adb...da722cc. Read the comment docs.

@supaiku0 supaiku0 merged commit f0fa7e8 into develop Mar 11, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
ci/circleci: test-node10-1 Your tests passed on CircleCI!
ci/circleci: test-node10-2 Your tests passed on CircleCI!
ci/circleci: test-node11-0 Your tests passed on CircleCI!
ci/circleci: test-node11-1 Your tests passed on CircleCI!
ci/circleci: test-node11-2 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the chore/deps branch Mar 11, 2019

vasild added a commit that referenced this pull request Mar 11, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  chore: update dependencies and remove unused imports (#2212)
  fix(core-tester-cli): Don't hide errors from HTTP failures (#2223)
  chore: update CircleCI config
  chore: use yarn setup on CircleCI
  fix: resolve core-tester-utils conflicts and various errors
  chore: yarn.lock
  chore: bump versions
  chore: resolve conflicts
  refactor(core): allow to provide yes/no callbacks for confirm
  feat(core): suggest another command if the requested one was not found
  fix(core): only quote string flags that contain whitespace
  fix(core-blockchain): node stuck during sync  (#2220)
  docs: add #2217 to the changelog
  refactor(core): use restart instead of reload
  refactor(core): log the stderr output for pm2 errors
  refactor(core): handle pm2 errors outside of the process manager
  refactor(core): log the pm2 status if it is unknown
  refactor(core-p2p): log concise error message instead of dumping the reply (#2215)
  fix(core-blockchain): return if last downloaded block changed (#2216)
  fix(core-transaction-pool): invalid transactions after rollback (#2217)
  feat(core-p2p): Don't spoil the quorum if the peer has !forgingAllowed (#2214)
  fix(core): escape string flags
  docs: add #2207 to the changelog
  refactor(core-forger): Increase timeout for getting the network state (#2208)
  fix: vote balance update (#2207)
  fix(core): exclude undefined values from string casting
  build(docker): use latest release in production images
  chore: install stable release via setup script
  test(core-p2p): toBeGreaterThanOrEqual instead of toBe
  release: 2.2.0
  chore: bump version
  fix: schema
  fix: max payload size
  fix: quorum issues (#2091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.