Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-tester-cli): Fix the description of debug:serialize #2213

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@vasild
Copy link
Contributor

vasild commented Mar 8, 2019

The string provided as an input is supposed to be JSON that is to be
serialized.

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
fix(core-tester-cli): Fix the description of debug:serialize
The string provided as an input is supposed to be JSON that is to be
serialized.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #2213 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2213   +/-   ##
========================================
  Coverage    77.28%   77.28%           
========================================
  Files          317      317           
  Lines         8267     8267           
  Branches      1130     1091   -39     
========================================
  Hits          6389     6389           
  Misses        1846     1846           
  Partials        32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0479d01...183eab1. Read the comment docs.

@vasild vasild merged commit 183eab1 into develop Mar 8, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix-serialize-description branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.