Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add restart flags to update command #2218

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@dated
Copy link
Contributor

dated commented Mar 10, 2019

Proposed changes

Adds the option to pass flags to the update command to specify the restart behaviour without prompting for user input:

  • --restart: restarts all (running) processes
  • --no-restart: no process will be restarted
  • --restart-core: restarts the core process
  • --restart-relay: restarts the relay process
  • --restart-forger: restarts the forger process

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@dated

This comment has been minimized.

Copy link
Contributor Author

dated commented Mar 10, 2019

Does the PR need approval before I can switch from draft to normal? 🤔

@faustbrian
Copy link
Collaborator

faustbrian left a comment

Looks fine for now, will change it a bit later.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 11, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian marked this pull request as ready for review Mar 11, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Mar 11, 2019

@faustbrian faustbrian merged commit ae3c428 into ArkEcosystem:develop Mar 11, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 11, 2019

Your pull request has been merged and marked as tier 3. It will earn you $25 USD.

@dated dated deleted the dated:update-restart-flags branch Mar 11, 2019

vasild added a commit that referenced this pull request Mar 11, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  chore: circleci restore caching + re-organize jobs for unit / integration tests (#2222)
  feat(core): add restart flags to update command (#2218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.