Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: circleci restore caching + re-organize jobs for unit / integration tests #2222

Merged
merged 5 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@air1one
Copy link
Collaborator

air1one commented Mar 11, 2019

Proposed changes

CircleCI builds were becoming slow, around 6-7min.

  • Fixed caching : we were not using caching anymore because when doing yarn setup we'd basically remove all we had cached.
  • Re-organized circleci jobs : 1 job for all unit tests, and 2 jobs for integration tests.

Now jobs are faster : 3-4min.

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit e731c8f into develop Mar 11, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the circleci/cache branch Mar 11, 2019

vasild added a commit that referenced this pull request Mar 11, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  chore: circleci restore caching + re-organize jobs for unit / integration tests (#2222)
  feat(core): add restart flags to update command (#2218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.