Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): properly sort semver versions #2229

Merged
merged 2 commits into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@luciorubeens
Copy link
Member

luciorubeens commented Mar 12, 2019

Proposed changes

Sort the peers by version.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Show resolved Hide resolved .circleci/config.yml Outdated

@luciorubeens luciorubeens force-pushed the luciorubeens:fix/sort-semver branch from 5b02d7e to 38e0913 Mar 12, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #2229 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2229      +/-   ##
===========================================
+ Coverage    73.29%   73.32%   +0.02%     
===========================================
  Files          318      318              
  Lines         7213     7217       +4     
  Branches       368      369       +1     
===========================================
+ Hits          5287     5292       +5     
+ Misses        1884     1883       -1     
  Partials        42       42
Impacted Files Coverage Δ
...ckages/core-api/src/versions/2/peers/controller.ts 70.58% <100%> (+7.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca8f61...3e68fc1. Read the comment docs.

@faustbrian faustbrian merged commit c123959 into ArkEcosystem:develop Mar 12, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

vasild added a commit that referenced this pull request Mar 12, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  fix(core-api): properly sort semver versions (#2229)
  feat(core-tester-cli): add make:block command (#2221)
  refactor: replace axios with got (#2203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.