Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): keep old vendor field padding #2233

merged 1 commit into from Mar 13, 2019


None yet
4 participants
Copy link

supaiku0 commented Mar 12, 2019

Proposed changes

Don't touch the vendor field padding of the legacy serialization format. Unbreaks devnet for nodes on develop now that the vendorfield length milestone has been reached.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

This comment has been minimized.

Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #2233 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2233   +/-   ##
  Coverage    73.38%   73.38%           
  Files          318      318           
  Lines         7211     7211           
  Branches       331      331           
  Hits          5292     5292           
  Misses        1877     1877           
  Partials        42       42
Impacted Files Coverage Δ
...crypto/src/transactions/serializers/transaction.ts 95.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6b092...4cd6e81. Read the comment docs.

@faustbrian faustbrian merged commit 1e42dc1 into ArkEcosystem:develop Mar 13, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
ci/circleci: test-node10-1 Your tests passed on CircleCI!
ci/circleci: test-node10-2 Your tests passed on CircleCI!
ci/circleci: test-node11-0 Your tests passed on CircleCI!
ci/circleci: test-node11-1 Your tests passed on CircleCI!
ci/circleci: test-node11-2 Your tests passed on CircleCI!

vasild added a commit that referenced this pull request Mar 13, 2019

Merge remote-tracking branch 'ArkEcosystem/core/develop' into blockid
* ArkEcosystem/core/develop:
  fix: properly cast Buffer to hex string (#2232)
  fix: keep old vendor field padding (#2233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.