Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-database-postgres): transaction asset column #2236

Merged
merged 9 commits into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Mar 14, 2019

Proposed changes

As part of AIP29 the transaction asset field needs to be stored directly in the transactions table. A nice side effect is that the integrity verifier can now directly query transaction assets without having to deserialize which greatly speeds up the node startup.

The inital migration may take up to a few minutes since it needs to populate the asset column for all existing records.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 14, 2019

The ci/circleci: test-node11-2 job is failing as of a93f2a171e61f49d000aaae15753e0e37f13996e. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 14, 2019

The ci/circleci: test-node10-1 job is failing as of a93f2a171e61f49d000aaae15753e0e37f13996e. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #2236 into develop will increase coverage by 0.01%.
The diff coverage is 27.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2236      +/-   ##
===========================================
+ Coverage    73.34%   73.35%   +0.01%     
===========================================
  Files          319      319              
  Lines         7237     7240       +3     
  Branches       373      338      -35     
===========================================
+ Hits          5308     5311       +3     
  Misses        1887     1887              
  Partials        42       42
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 32.19% <ø> (+0.15%) ⬆️
packages/core-p2p/src/monitor.ts 39.2% <ø> (-0.27%) ⬇️
...ypto/src/transactions/deserializers/transaction.ts 90.32% <0%> (+2.82%) ⬆️
...s/core-database-postgres/src/models/transaction.ts 100% <100%> (ø) ⬆️
...kages/crypto/src/transactions/types/transaction.ts 86.53% <100%> (+0.53%) ⬆️
.../core-database-postgres/src/postgres-connection.ts 59.57% <16.66%> (-3.96%) ⬇️
...s/core-database-postgres/src/integrity-verifier.ts 9.63% <20%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e607f7a...ac4d486. Read the comment docs.

@faustbrian faustbrian merged commit 3be82e8 into ArkEcosystem:develop Mar 14, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.