Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move wallet class out of crypto #2237

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Mar 14, 2019

Proposed changes

The Wallet class belongs next to the WalletManager in core-database.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #2237 into develop will decrease coverage by <.01%.
The diff coverage is 88.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2237      +/-   ##
===========================================
- Coverage    73.34%   73.34%   -0.01%     
===========================================
  Files          319      319              
  Lines         7238     7237       -1     
  Branches       373      373              
===========================================
- Hits          5309     5308       -1     
  Misses        1887     1887              
  Partials        42       42
Impacted Files Coverage Δ
...ore-transactions/src/services/timelock-transfer.ts 57.14% <ø> (ø) ⬆️
...-transactions/src/services/delegate-resignation.ts 50% <100%> (ø) ⬆️
...ackages/core-transactions/src/services/transfer.ts 66.66% <100%> (ø) ⬆️
...transactions/src/services/delegate-registration.ts 44.82% <100%> (ø) ⬆️
...es/core-transactions/src/services/multi-payment.ts 57.14% <100%> (ø) ⬆️
packages/core-forger/src/manager.ts 70% <100%> (ø) ⬆️
packages/core-transactions/src/services/vote.ts 82.6% <100%> (ø) ⬆️
packages/core-transactions/src/services/ipfs.ts 57.14% <100%> (ø) ⬆️
...ages/core-transactions/src/services/transaction.ts 79.41% <100%> (ø) ⬆️
...core-transactions/src/services/second-signature.ts 90% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a5e71...ad075d3. Read the comment docs.

@faustbrian faustbrian merged commit e607f7a into ArkEcosystem:develop Mar 14, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.