Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Disable webhooks on testnet #2239

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@vasild
Copy link
Contributor

vasild commented Mar 14, 2019

Summary

chore(core): Disable webhooks on testnet

Webhooks are disabled on devnet and mainnet by default. Do the same with
testnet for consistency and because webhooks are broken and prevent
testnet from functioning:

$ yarn --cwd packages/core full:testnet
...
(node:44847) UnhandledPromiseRejectionWarning: TypeError: webhooks is not iterable
at WebhookManager.getMatchingWebhooks (core/packages/core-webhooks/dist/manager.js:47:31)

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:
    Disable broken component

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Other information

chore(core): Disable webhooks on testnet
Webhooks are disabled on devnet and mainnet by default. Do the same with
testnet for consistency and because webhooks are broken and prevent
testnet from functioning:

$ yarn --cwd packages/core full:testnet
...
(node:44847) UnhandledPromiseRejectionWarning: TypeError: webhooks is not iterable
    at WebhookManager.getMatchingWebhooks (core/packages/core-webhooks/dist/manager.js:47:31)

@vasild vasild requested review from faustbrian , kristjank and supaiku0 as code owners Mar 14, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 14, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@vasild vasild changed the title <!-- Please don't delete this template and read our contribution guidelines at https://docs.ark.io/guidebook/contribution-guidelines/contributing.html --> chore(core): Disable webhooks on testnet Mar 14, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #2239 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2239   +/-   ##
========================================
  Coverage    73.35%   73.35%           
========================================
  Files          319      319           
  Lines         7240     7240           
  Branches       338      375   +37     
========================================
  Hits          5311     5311           
  Misses        1887     1887           
  Partials        42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d841953...9f2e03c. Read the comment docs.

@faustbrian faustbrian merged commit c7d5b8c into develop Mar 14, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the disable-webhooks-on-testnet branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.