Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pretest and lint scripts from packages #2243

Merged
merged 3 commits into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Mar 14, 2019

Proposed changes

Remove the pretest and lint scripts from individual packages.

  • The yarn build command in the root of the repository should be used instead to build all packages before.
  • The yarn format command in the root of the repository should be used instead to lint and format all packages.

Types of changes

  • Other

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 14, 2019

The ci/circleci: test-node11-1 job is failing as of ec2af3bc33a84e4619e39869cf1eb6166a14f130. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #2243 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2243   +/-   ##
========================================
  Coverage    73.35%   73.35%           
========================================
  Files          319      319           
  Lines         7240     7240           
  Branches       338      375   +37     
========================================
  Hits          5311     5311           
  Misses        1887     1887           
  Partials        42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bfc0f...ec2af3b. Read the comment docs.

@faustbrian faustbrian merged commit bda844d into develop Mar 14, 2019

6 checks passed

ci/circleci: test-node10-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-2 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the pretest branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.