Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: websockets (socketcluster) for p2p communication #2273

Merged
merged 72 commits into from Apr 2, 2019

Conversation

Projects
None yet
5 participants
@air1one
Copy link
Collaborator

air1one commented Mar 21, 2019

Proposed changes

Use websockets instead of current http api for p2p communication.

Resolves #1589.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

air1one added some commits Feb 11, 2019

@supaiku0
Copy link
Contributor

supaiku0 left a comment

Please add the type definitions for socketcluster and scc-broker-client.

@@ -1,3 +1,8 @@
export const defaults = {
hosts: [`http://127.0.0.1:${process.env.CORE_P2P_PORT || 4002}`],
hosts: [

This comment has been minimized.

Copy link
@faustbrian

faustbrian Mar 25, 2019

Collaborator

The packages/core/bin/config/**/plugins.js files also need to be updated. We can simply remove the defaults from the plugins.js files as the defaults in this file should rarely need to be changed.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 27, 2019

The ci/circleci: test-node11-functional job is failing as of 82c39c5b5cb90cf66d01b8a79313df30855cf066. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Types were added

@faustbrian faustbrian merged commit 34a7560 into 2.4 Apr 2, 2019

10 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the feat/p2p-socketcluster branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.