Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-blockchain): initialize active delegates on startup #2353

Merged

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Apr 2, 2019

Proposed changes

Fixes #2350

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 2, 2019

The ci/circleci: test-node11-integration-2 job is failing as of be250e2ddb7f94b984ede0bbef4c63be907837c5. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 2, 2019

The ci/circleci: test-node10-integration-0 job is failing as of 20bf4b1fa126f7a2006d6ad755833802751d0afa. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

supaiku0 added some commits Apr 2, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #2353 into develop will decrease coverage by 0.14%.
The diff coverage is 52.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2353      +/-   ##
===========================================
- Coverage    66.01%   65.87%   -0.15%     
===========================================
  Files          400      400              
  Lines         8555     8538      -17     
  Branches       374      375       +1     
===========================================
- Hits          5648     5624      -24     
- Misses        2864     2871       +7     
  Partials        43       43
Impacted Files Coverage Δ
packages/core-blockchain/src/blockchain.ts 89.47% <ø> (-1.5%) ⬇️
...crypto/src/transactions/serializers/transaction.ts 95.49% <100%> (-0.05%) ⬇️
packages/crypto/src/crypto/crypto.ts 95.74% <100%> (+0.09%) ⬆️
packages/core-blockchain/src/state-machine.ts 95.41% <100%> (-0.07%) ⬇️
packages/core-database/src/database-service.ts 30.87% <38.46%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9355f1a...26b51cb. Read the comment docs.

@faustbrian faustbrian merged commit 3178426 into ArkEcosystem:develop Apr 2, 2019

10 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.