Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-database): round logic #2358

Merged
merged 12 commits into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Apr 3, 2019

Proposed changes

Removes some obsolete code, adds type hints and improves the round logic which now also handles the network start better. There will be more changes in an upcoming PR.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #2358 into develop will decrease coverage by <.01%.
The diff coverage is 67.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2358      +/-   ##
===========================================
- Coverage    66.05%   66.04%   -0.01%     
===========================================
  Files          400      400              
  Lines         8523     8512      -11     
  Branches       377      377              
===========================================
- Hits          5630     5622       -8     
+ Misses        2850     2847       -3     
  Partials        43       43
Impacted Files Coverage Δ
...s/core-database-postgres/src/integrity-verifier.ts 9.75% <ø> (+0.11%) ⬆️
...ages/core-transactions/src/handlers/transaction.ts 76.66% <ø> (-2.75%) ⬇️
packages/core-database/src/wallet.ts 94.44% <ø> (-0.23%) ⬇️
packages/core-utils/src/round-calculator.ts 100% <100%> (ø) ⬆️
packages/core-database/src/database-service.ts 29.57% <35.71%> (-1.3%) ⬇️
packages/core-p2p/src/peer-verifier.ts 75.63% <80%> (-0.21%) ⬇️
packages/core-database/src/wallet-manager.ts 75.81% <80%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b41b3...9f17c08. Read the comment docs.

@faustbrian faustbrian merged commit 52b229b into ArkEcosystem:develop Apr 3, 2019

10 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.