Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-api): add rounds endpoint #2369

Merged
merged 6 commits into from Apr 7, 2019

Conversation

Projects
None yet
3 participants
@dated
Copy link
Contributor

dated commented Apr 6, 2019

Proposed changes

Adds an additional endpoint (rounds/{id}/delegates) to the API to retrieve the forging delegates and their vote balance in a given round (use case: display rank changes in the explorer).

{
    "data": [
        {
            "publicKey": "033a5474f68f92f254691e93c06a2f22efaf7d66b543a53efcece021819653a200",
            "votes": 198439096320375
        },
        {
            "publicKey": "03bbfb43ecb5a54a1e227bb37b5812b5321213838d376e2b455b6af78442621dec",
            "votes": 48916602782154
        },
        {
            "publicKey": "03120f521f7025f76341a09112f88a6c072411c549e4bfa8c92946fcf1c57cdf1e",
            "votes": 14939602596061
        },
        ...
    ]
}

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

faustbrian and others added some commits Apr 5, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 6, 2019

The ci/circleci: test-node11-integration-1 job is failing as of 2ed40e84086cd183b6f01c063a5be94f185c0ee1. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@dated dated marked this pull request as ready for review Apr 6, 2019

@dated dated requested review from faustbrian, kristjank and supaiku0 as code owners Apr 6, 2019

@faustbrian

This comment has been minimized.

Copy link
Collaborator

faustbrian commented Apr 7, 2019

@dated please target this towards 2.4

@dated dated changed the base branch from develop to 2.4 Apr 7, 2019

@faustbrian

This comment has been minimized.

Copy link
Collaborator

faustbrian commented Apr 7, 2019

Some changes from develop are still included.

@dated

This comment has been minimized.

Copy link
Contributor Author

dated commented Apr 7, 2019

I see 477cd01 in there. I'll revert those changes ASAP.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 7, 2019

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 3646ed5 into ArkEcosystem:2.4 Apr 7, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 7, 2019

Your pull request has been merged and marked as tier 2. It will earn you $50 USD.

@dated dated deleted the dated:rounds-api branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.