Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cope with dynamic round sizes #2370

Merged
merged 21 commits into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@supaiku0
Copy link
Contributor

supaiku0 commented Apr 6, 2019

Proposed changes

Core assumed the round size never changes after the first round. Thus it was actually impossible to change the number of delegates via milestone at a later time.

With this PR Core is able to cope with dynamic round sizes.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 6, 2019

Codecov Report

Merging #2370 into develop will increase coverage by 0.1%.
The diff coverage is 65.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #2370     +/-   ##
==========================================
+ Coverage    66.05%   66.15%   +0.1%     
==========================================
  Files          400      400             
  Lines         8520     8581     +61     
  Branches       419      382     -37     
==========================================
+ Hits          5628     5677     +49     
- Misses        2847     2860     +13     
+ Partials        45       44      -1
Impacted Files Coverage Δ
packages/crypto/src/crypto/slots.ts 100% <ø> (ø) ⬆️
packages/core-snapshots/src/manager.ts 0% <0%> (ø) ⬆️
packages/core-forger/src/manager.ts 65.55% <0%> (-3.86%) ⬇️
...2p/src/server/versions/internal/handlers/rounds.ts 0% <0%> (ø) ⬆️
...kchain/src/processor/handlers/unchained-handler.ts 91.93% <100%> (+0.26%) ⬆️
...es/core-blockchain/src/utils/validate-generator.ts 100% <100%> (ø) ⬆️
...s/core-transaction-pool/src/pool-wallet-manager.ts 96.42% <100%> (ø) ⬆️
packages/core-utils/src/round-calculator.ts 100% <100%> (ø) ⬆️
packages/core-vote-report/src/handler.ts 100% <100%> (ø) ⬆️
packages/core-blockchain/src/state-machine.ts 95.41% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f6ee8...9efe764. Read the comment docs.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 6, 2019

The ci/circleci: test-node11-unit job is failing as of 89218f6acd9408a291fcff76a60fdf7e5bc7786a. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

1 similar comment
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 6, 2019

The ci/circleci: test-node11-unit job is failing as of 89218f6acd9408a291fcff76a60fdf7e5bc7786a. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

supaiku0 and others added some commits Apr 6, 2019

@faustbrian faustbrian merged commit 806733b into ArkEcosystem:develop Apr 8, 2019

10 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.