Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forget peer connection on disconnect #2386

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@air1one
Copy link
Collaborator

air1one commented Apr 9, 2019

Proposed changes

Not only destroy socket on peer disconnect, but also forget the peer connection from our connections list.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 25d9a67 into 2.4 Apr 9, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/p2p-disconnect branch Apr 9, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #2386 into 2.4 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              2.4   #2386      +/-   ##
=========================================
+ Coverage   68.09%   68.1%   +<.01%     
=========================================
  Files         405     405              
  Lines        8564    8565       +1     
  Branches      381     423      +42     
=========================================
+ Hits         5832    5833       +1     
+ Misses       2693    2692       -1     
- Partials       39      40       +1
Impacted Files Coverage Δ
packages/core-p2p/src/peer-connector.ts 95.23% <100%> (+0.23%) ⬆️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1195396...b841378. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.