Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enforce BigNumber for satoshi based values #2391

Merged
merged 8 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 10, 2019

Proposed changes

Part of #2206 - Only Utils.Bignum is now a valid type for any satoshi based values, string and number will no longer work.

To-Do

  • Adjust failing tests and old fixtures

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 10, 2019

The ci/circleci: test-node11-integration-0 job is failing as of b8701e50feda89179208b31a88faca199e10152a. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian marked this pull request as ready for review Apr 10, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Apr 10, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #2391 into 2.4 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              2.4   #2391      +/-   ##
=========================================
+ Coverage   68.09%   68.1%   +<.01%     
=========================================
  Files         405     405              
  Lines        8565    8552      -13     
  Branches      380     378       -2     
=========================================
- Hits         5832    5824       -8     
+ Misses       2694    2689       -5     
  Partials       39      39
Impacted Files Coverage Δ
packages/core-snapshots/src/transport/codec.ts 100% <ø> (ø) ⬆️
packages/core-tester-cli/src/signer.ts 88.23% <ø> (ø) ⬆️
packages/crypto/src/crypto/crypto.ts 95.74% <ø> (ø) ⬆️
packages/crypto/src/blocks/block.ts 90.65% <100%> (+0.08%) ⬆️
...pto/src/transactions/builders/transactions/vote.ts 100% <100%> (ø) ⬆️
...pto/src/transactions/builders/transactions/ipfs.ts 72% <100%> (+1.16%) ⬆️
packages/crypto/src/managers/fee.ts 100% <100%> (ø) ⬆️
...s/core-transaction-pool/src/dynamic-fee/matcher.ts 97.14% <100%> (ø) ⬆️
...nsactions/builders/transactions/multi-signature.ts 100% <100%> (ø) ⬆️
packages/core-utils/src/delegate-calculator.ts 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74aba20...955d3a6. Read the comment docs.

@faustbrian faustbrian merged commit df9fd4d into 2.4 Apr 10, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/bignum branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.