Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-api): add v2/node/fees endpoint #2393

Merged
merged 11 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 10, 2019

Proposed changes

Resolves #2279

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 10, 2019

The ci/circleci: test-node10-integration-1 job is failing as of 5e146c7a0d96cc203cddc2f8697450a663e5d520. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #2393 into 2.4 will decrease coverage by 0.08%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff            @@
##             2.4    #2393      +/-   ##
=========================================
- Coverage   68.1%   68.01%   -0.09%     
=========================================
  Files        405      406       +1     
  Lines       8552     8558       +6     
  Branches     378      421      +43     
=========================================
- Hits        5824     5821       -3     
- Misses      2689     2697       +8     
- Partials      39       40       +1
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 23.07% <ø> (ø) ⬆️
...kages/core-api/src/versions/1/loader/controller.ts 56.25% <ø> (-4.87%) ⬇️
packages/core-api/src/repositories/transactions.ts 81.45% <ø> (-0.44%) ⬇️
...c/repositories/transactions-business-repository.ts 97.1% <ø> (ø) ⬆️
packages/core-api/src/versions/2/node/routes.ts 100% <100%> (ø) ⬆️
packages/core-api/src/versions/2/node/schema.ts 100% <100%> (ø)
...ackages/core-api/src/versions/2/node/controller.ts 55.17% <22.22%> (-17.56%) ⬇️
...kages/core-api/src/versions/2/shared/controller.ts 84.61% <0%> (-7.7%) ⬇️
packages/core-api/src/versions/2/utils.ts 86.36% <0%> (-4.55%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9fd4d...6cf6430. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review Apr 10, 2019

@faustbrian faustbrian requested review from kristjank and supaiku0 as code owners Apr 10, 2019

faustbrian and others added some commits Apr 10, 2019

@faustbrian faustbrian merged commit 606d06d into 2.4 Apr 10, 2019

0 of 8 checks passed

ci/circleci: test-node10-functional Your tests are queued behind your running builds
Details
ci/circleci: test-node10-integration-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-integration-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node10-unit Your tests are queued behind your running builds
Details
ci/circleci: test-node11-functional Your tests are queued behind your running builds
Details
ci/circleci: test-node11-integration-0 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-integration-1 Your tests are queued behind your running builds
Details
ci/circleci: test-node11-unit Your tests are queued behind your running builds
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/fees branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.