Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crypto): bump vendorFieldLength and blockid activation heights #2395

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@vasild
Copy link
Contributor

vasild commented Apr 10, 2019

Due to 2.3 release re-schedule:

Height 8128000 at Thu Apr 25 12:05:22 UTC 2019 (assuming no block misses)
Height 8128000 at Thu Apr 25 12:37:13 UTC 2019 (assuming block misses as in the last 30000 blocks)

Height 8204000 at Thu May 2 12:58:42 UTC 2019 (assuming no block misses)
Height 8204000 at Thu May 2 13:45:25 UTC 2019 (assuming block misses as in the last 30000 blocks)

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
Bump vendorFieldLength and blockid activation heights
Due to 2.3 release re-schedule:

Height 8128000 at Thu Apr 25 12:05:22 UTC 2019 (assuming no block misses)
Height 8128000 at Thu Apr 25 12:37:13 UTC 2019 (assuming block misses as in the last 30000 blocks)

Height 8204000 at Thu May  2 12:58:42 UTC 2019 (assuming no block misses)
Height 8204000 at Thu May  2 13:45:25 UTC 2019 (assuming block misses as in the last 30000 blocks)

@vasild vasild requested a review from supaiku0 Apr 10, 2019

@vasild vasild requested review from faustbrian and kristjank as code owners Apr 10, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 10, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@faustbrian faustbrian changed the title Bump vendorFieldLength and blockid activation heights chore(crypto): bump vendorFieldLength and blockid activation heights Apr 10, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #2395 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2395      +/-   ##
===========================================
- Coverage    66.17%   66.15%   -0.02%     
===========================================
  Files          400      411      +11     
  Lines         8592     8676      +84     
  Branches       424      424              
===========================================
+ Hits          5686     5740      +54     
- Misses        2861     2891      +30     
  Partials        45       45
Impacted Files Coverage Δ
packages/core-transaction-pool/src/plugin.ts 100% <0%> (ø)
packages/core-blockchain/src/plugin.ts 83.33% <0%> (ø)
packages/core-logger-winston/src/plugin.ts 75% <0%> (ø)
packages/core-logger-pino/src/plugin.ts 75% <0%> (ø)
packages/core-p2p/src/plugin.ts 0% <0%> (ø)
packages/core-logger/src/plugin.ts 66.66% <0%> (ø)
packages/core-database/src/plugin.ts 50% <0%> (ø)
packages/core-database-postgres/src/plugin.ts 100% <0%> (ø)
packages/core-snapshots/src/plugin.ts 0% <0%> (ø)
packages/core-api/src/plugin.ts 80% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c01d7...b916083. Read the comment docs.

@faustbrian faustbrian merged commit 2770bfa into develop Apr 10, 2019

10 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the vendor-blockid-milestone-heights branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.