Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-event-emitter): add off method #2396

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 10, 2019

Proposed changes

Resolves #2392

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #2396 into develop will decrease coverage by 0.01%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2396      +/-   ##
===========================================
- Coverage    66.17%   66.16%   -0.02%     
===========================================
  Files          400      400              
  Lines         8592     8594       +2     
  Branches       424      424              
===========================================
  Hits          5686     5686              
- Misses        2861     2863       +2     
  Partials        45       45
Impacted Files Coverage Δ
packages/core-event-emitter/src/emitter.ts 61.53% <20%> (-11.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c01d7...f7cd460. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #2396 into develop will decrease coverage by 0.01%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2396      +/-   ##
===========================================
- Coverage    66.17%   66.16%   -0.02%     
===========================================
  Files          400      400              
  Lines         8592     8594       +2     
  Branches       424      424              
===========================================
  Hits          5686     5686              
- Misses        2861     2863       +2     
  Partials        45       45
Impacted Files Coverage Δ
packages/core-event-emitter/src/emitter.ts 61.53% <20%> (-11.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c01d7...f7cd460. Read the comment docs.

@faustbrian faustbrian merged commit 085b5a8 into develop Apr 10, 2019

10 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-2 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/emitter branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.