Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): make SocketCluster configurable #2399

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 11, 2019

Proposed changes

Allow passing in SC specific configuration and specifically log fail events as errors.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 11, 2019

The ci/circleci: test-node10-integration-1 job is failing as of 05cc424229aba481ed213dd1ad2d70e88e875814. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #2399 into 2.4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4    #2399   +/-   ##
=======================================
  Coverage   68.13%   68.13%           
=======================================
  Files         406      406           
  Lines        8639     8639           
  Branches      383      383           
=======================================
  Hits         5886     5886           
  Misses       2714     2714           
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e768895...3cdcd48. Read the comment docs.

@faustbrian faustbrian merged commit d4914c0 into 2.4 Apr 11, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/sc-conf branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.