Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): simplify handlers and remove dead code #2400

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 11, 2019

Proposed changes

Reduce noise around handlers and simplify a few things.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 11, 2019

The ci/circleci: test-node11-unit job is failing as of 715f7dab871b4beee0cabd721df317b7ea80d936. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #2400 into 2.4 will decrease coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##              2.4   #2400      +/-   ##
=========================================
- Coverage   68.13%   68.1%   -0.03%     
=========================================
  Files         406     401       -5     
  Lines        8639    8629      -10     
  Branches      383     426      +43     
=========================================
- Hits         5886    5877       -9     
+ Misses       2714    2712       -2     
- Partials       39      40       +1
Impacted Files Coverage Δ
packages/core-blockchain/src/blockchain.ts 52.63% <ø> (ø) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 100% <100%> (ø)
packages/core-p2p/src/socket-server/worker.ts 25% <33.33%> (+1.54%) ⬆️
...kages/core-p2p/src/socket-server/versions/utils.ts 91.66% <91.66%> (ø)
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e768895...1dd9d6e. Read the comment docs.

@faustbrian faustbrian merged commit bd135d2 into 2.4 Apr 11, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/sc-handlers branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.