Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): suspend peers if they exceed the rate limit #2401

Merged
merged 8 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 11, 2019

Proposed changes

Instead of keeping a separate banning list we suspend peers with tooManyRequests.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 11, 2019

The ci/circleci: test-node10-unit job is failing as of 744cabbd44622df3417aec2a36b79fac85bea044. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #2401 into 2.4 will increase coverage by 0.1%.
The diff coverage is 55.07%.

Impacted file tree graph

@@           Coverage Diff            @@
##             2.4    #2401     +/-   ##
========================================
+ Coverage   68.1%   68.21%   +0.1%     
========================================
  Files        401      401             
  Lines       8629     8613     -16     
  Branches     383      380      -3     
========================================
- Hits        5877     5875      -2     
+ Misses      2713     2699     -14     
  Partials      39       39
Impacted Files Coverage Δ
packages/core-forger/src/client.ts 69.38% <100%> (ø) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 100% <100%> (ø) ⬆️
packages/core-p2p/src/socket-server/worker.ts 28.12% <28.57%> (+3.12%) ⬆️
...kages/core-p2p/src/socket-server/versions/utils.ts 94.44% <91.66%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344dc97...a138c2f. Read the comment docs.

@faustbrian faustbrian requested a review from air1one as a code owner Apr 11, 2019

@faustbrian faustbrian merged commit 6c80eaa into 2.4 Apr 11, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/sc-suspension branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.