Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-database): return boolean from verifyBlockchain and log errors #2403

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 11, 2019

Proposed changes

verify* methods should only return booleans for state indication. If any errors were detected they will be logged before the method returns.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 11, 2019

The ci/circleci: test-node11-integration-0 job is failing as of ce6c616dfd75690e30d3d63f2da595db5eb46b54. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #2403 into 2.4 will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2403      +/-   ##
==========================================
- Coverage   68.21%   68.16%   -0.05%     
==========================================
  Files         401      401              
  Lines        8613     8610       -3     
  Branches      423      380      -43     
==========================================
- Hits         5875     5869       -6     
- Misses       2698     2702       +4     
+ Partials       40       39       -1
Impacted Files Coverage Δ
packages/core-blockchain/src/state-machine.ts 89.07% <ø> (-0.53%) ⬇️
packages/core-database/src/database-service.ts 28.44% <0%> (-0.39%) ⬇️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c80eaa...c40b5c3. Read the comment docs.

@supaiku0 supaiku0 merged commit c7c7ce4 into 2.4 Apr 11, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/verify-blockchain branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.