Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): store connection errors in connector #2408

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 12, 2019

Proposed changes

Resolves @TODO: store errors in the PeerConnector.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #2408 into 2.4 will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2408      +/-   ##
==========================================
+ Coverage   68.29%   68.31%   +0.01%     
==========================================
  Files         402      402              
  Lines        8668     8673       +5     
  Branches      435      392      -43     
==========================================
+ Hits         5920     5925       +5     
- Misses       2704     2705       +1     
+ Partials       44       43       -1
Impacted Files Coverage Δ
packages/core-p2p/src/peer-guard.ts 79.06% <ø> (ø) ⬆️
packages/core-p2p/src/peer.ts 100% <ø> (ø) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 79.62% <0%> (ø) ⬆️
packages/core-p2p/src/peer-connector.ts 96.29% <100%> (+0.84%) ⬆️
packages/core-p2p/src/peer-communicator.ts 75.6% <100%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec1872...d51dc91. Read the comment docs.

@supaiku0 supaiku0 merged commit da3d358 into 2.4 Apr 12, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/socket-error branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.