Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): suspend a peer directly with the noCommonBlocks punishment #2409

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 12, 2019

Proposed changes

Removes the peer.commonBlocks property which was only used to suspend a peer and instead directly emits a suspension with the noCommonBlocks punishment.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #2409 into 2.4 will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2409      +/-   ##
==========================================
+ Coverage   68.31%   68.32%   +0.01%     
==========================================
  Files         402      402              
  Lines        8673     8670       -3     
  Branches      392      435      +43     
==========================================
- Hits         5925     5924       -1     
+ Misses       2705     2702       -3     
- Partials       43       44       +1
Impacted Files Coverage Δ
packages/core-p2p/src/peer.ts 100% <ø> (ø) ⬆️
packages/core-p2p/src/peer-guard.ts 80.48% <ø> (+1.41%) ⬆️
packages/core-p2p/src/peer-communicator.ts 76.54% <0%> (+0.93%) ⬆️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da3d358...c0ce7b6. Read the comment docs.

@faustbrian faustbrian merged commit f1189e4 into 2.4 Apr 12, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/peer-cmmon branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.