Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(p2p): remove the status property from peers #2410

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 12, 2019

Proposed changes

Removes the unused peer.status property.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian added some commits Apr 12, 2019

@faustbrian faustbrian merged commit ca6e002 into 2.4 Apr 12, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/peer-status branch Apr 12, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #2410 into 2.4 will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2410      +/-   ##
==========================================
- Coverage   68.32%   68.31%   -0.02%     
==========================================
  Files         402      402              
  Lines        8670     8663       -7     
  Branches      392      432      +40     
==========================================
- Hits         5924     5918       -6     
+ Misses       2703     2701       -2     
- Partials       43       44       +1
Impacted Files Coverage Δ
packages/core-p2p/src/peer.ts 100% <ø> (ø) ⬆️
...ckages/core-api/src/versions/2/peers/controller.ts 67.74% <ø> (-1.96%) ⬇️
...ckages/core-api/src/versions/1/peers/controller.ts 70.96% <100%> (-1.26%) ⬇️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1189e4...2bd1d9b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.