Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): add peer state interface #2411

Merged
merged 4 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 12, 2019

Proposed changes

Add an interface for the peer.state property.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 12, 2019

The ci/circleci: test-node10-integration-0 job is failing as of a2dc606475af52c86e03e759ff5841889b32f185. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Apr 12, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #2411 into 2.4 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4    #2411   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files         402      402           
  Lines        8663     8663           
  Branches      391      432   +41     
=======================================
  Hits         5918     5918           
+ Misses       2702     2701    -1     
- Partials       43       44    +1
Impacted Files Coverage Δ
packages/core-p2p/src/peer.ts 100% <100%> (ø) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 79.62% <100%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6e002...9c623c2. Read the comment docs.

@faustbrian faustbrian merged commit 156c0a3 into 2.4 Apr 12, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/peer-state branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.