Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-forger): add interfaces, type hints and remove comments #2412

Merged
merged 3 commits into from Apr 13, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 13, 2019

Proposed changes

Adds missing interfaces, type hints and renames some methods to remove the need for comments.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 13, 2019

The ci/circleci: test-node10-integration-0 job is failing as of b3ad70ad30b5621664205540c57b0d045b9909c3. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit 1a860d6 into 2.4 Apr 13, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/forger-types branch Apr 13, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #2412 into 2.4 will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2412      +/-   ##
==========================================
- Coverage   68.31%   68.29%   -0.02%     
==========================================
  Files         402      402              
  Lines        8663     8658       -5     
  Branches      391      392       +1     
==========================================
- Hits         5918     5913       -5     
+ Misses       2702     2701       -1     
- Partials       43       44       +1
Impacted Files Coverage Δ
packages/core-blockchain/src/state-machine.ts 88.98% <ø> (ø) ⬆️
packages/crypto/src/blocks/block.ts 90.65% <ø> (ø) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 79.62% <ø> (ø) ⬆️
packages/core-p2p/src/utils/socket.ts 100% <100%> (ø) ⬆️
packages/core-forger/src/delegate.ts 100% <100%> (ø) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 100% <100%> (ø) ⬆️
packages/core-forger/src/manager.ts 65.16% <64.7%> (-0.39%) ⬇️
packages/core-forger/src/client.ts 67.39% <72.72%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156c0a3...5a82951. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.