Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass IBlockData instead of IBlock to isBlockChained #2413

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 13, 2019

Proposed changes

Removes the need for hacks like casting with as IBlockData or using @ts-ignore as the function only works with IBlockData and never used any instance props or functions of IBlock.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #2413 into 2.4 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4    #2413   +/-   ##
=======================================
  Coverage   68.29%   68.29%           
=======================================
  Files         402      402           
  Lines        8658     8658           
  Branches      432      432           
=======================================
  Hits         5913     5913           
  Misses       2700     2700           
  Partials       45       45
Impacted Files Coverage Δ
...ckages/core-p2p/src/socket-server/versions/peer.ts 79.62% <ø> (ø) ⬆️
packages/core-blockchain/src/blockchain.ts 52.98% <ø> (ø) ⬆️
packages/core-utils/src/is-block-chained.ts 100% <100%> (ø) ⬆️
packages/core-blockchain/src/state-machine.ts 88.98% <100%> (ø) ⬆️
...s/core-blockchain/src/processor/block-processor.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a860d6...c529c79. Read the comment docs.

@faustbrian faustbrian merged commit 7c97812 into 2.4 Apr 13, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/isBlockChained branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.