Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hint IBlock/ITransactions instead of Block/Transaction #2414

Merged
merged 6 commits into from Apr 13, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 13, 2019

Proposed changes

Hint IBlock and ITransaction instead of their concrete implementations Blocks.Block and Transactions.Transaction.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 13, 2019

The ci/circleci: test-node10-unit job is failing as of 7de807e1fa59a384b9b79700447bd8922053484d. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian marked this pull request as ready for review Apr 13, 2019

@faustbrian faustbrian merged commit edeebd3 into 2.4 Apr 13, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #2414 into 2.4 will decrease coverage by 0.03%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2414      +/-   ##
==========================================
- Coverage   68.29%   68.26%   -0.04%     
==========================================
  Files         402      402              
  Lines        8658     8649       -9     
  Branches      392      433      +41     
==========================================
- Hits         5913     5904       -9     
+ Misses       2701     2699       -2     
- Partials       44       46       +2
Impacted Files Coverage Δ
...core-transactions/src/handlers/second-signature.ts 90% <ø> (ø) ⬆️
packages/core-database/src/wallet-manager.ts 74.83% <ø> (ø) ⬆️
...transactions/src/handlers/delegate-registration.ts 44.82% <ø> (ø) ⬆️
...ages/core-transactions/src/handlers/transaction.ts 76.66% <ø> (ø) ⬆️
packages/core-transactions/src/handlers/vote.ts 82.6% <ø> (ø) ⬆️
packages/core-p2p/src/peer-communicator.ts 76.54% <ø> (ø) ⬆️
...ackages/core-transactions/src/handlers/transfer.ts 66.66% <ø> (ø) ⬆️
packages/core-transaction-pool/src/guard.ts 97.4% <ø> (ø) ⬆️
packages/core-forger/src/client.ts 67.39% <ø> (ø) ⬆️
packages/crypto/src/blocks/serializer.ts 94.59% <ø> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c97812...5ff75a5. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 13, 2019

Codecov Report

Merging #2414 into 2.4 will decrease coverage by 0.03%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2414      +/-   ##
==========================================
- Coverage   68.29%   68.26%   -0.04%     
==========================================
  Files         402      402              
  Lines        8658     8649       -9     
  Branches      392      433      +41     
==========================================
- Hits         5913     5904       -9     
+ Misses       2701     2699       -2     
- Partials       44       46       +2
Impacted Files Coverage Δ
...core-transactions/src/handlers/second-signature.ts 90% <ø> (ø) ⬆️
packages/core-database/src/wallet-manager.ts 74.83% <ø> (ø) ⬆️
...transactions/src/handlers/delegate-registration.ts 44.82% <ø> (ø) ⬆️
...ages/core-transactions/src/handlers/transaction.ts 76.66% <ø> (ø) ⬆️
packages/core-transactions/src/handlers/vote.ts 82.6% <ø> (ø) ⬆️
packages/core-p2p/src/peer-communicator.ts 76.54% <ø> (ø) ⬆️
...ackages/core-transactions/src/handlers/transfer.ts 66.66% <ø> (ø) ⬆️
packages/core-transaction-pool/src/guard.ts 97.4% <ø> (ø) ⬆️
packages/core-forger/src/client.ts 67.39% <ø> (ø) ⬆️
packages/crypto/src/blocks/serializer.ts 94.59% <ø> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c97812...5ff75a5. Read the comment docs.

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/crypto-interfaces branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.