Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add more interfaces and types #2415

Merged
merged 19 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 13, 2019

Proposed changes

Add more interfaces and types or modify existing ones to get rid of any.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 13, 2019

The ci/circleci: test-node11-unit job is failing as of 3b4b2e636eda9ec6d10939ecd5c89acc13f589fa. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #2415 into 2.4 will increase coverage by 0.03%.
The diff coverage is 63.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2415      +/-   ##
==========================================
+ Coverage   68.26%   68.29%   +0.03%     
==========================================
  Files         402      402              
  Lines        8649     8615      -34     
  Branches      433      393      -40     
==========================================
- Hits         5904     5884      -20     
+ Misses       2699     2686      -13     
+ Partials       46       45       -1
Impacted Files Coverage Δ
...database-postgres/src/repositories/transactions.ts 23.07% <ø> (ø) ⬆️
...ase/src/repositories/blocks-business-repository.ts 81.25% <ø> (ø) ⬆️
packages/core-utils/src/has-some-property.ts 100% <ø> (ø) ⬆️
.../core-database-postgres/src/repositories/blocks.ts 31.42% <ø> (ø) ⬆️
packages/core-p2p/src/utils/socket.ts 100% <ø> (ø) ⬆️
packages/core-p2p/src/network-monitor.ts 64.32% <ø> (ø) ⬆️
packages/core-elasticsearch/src/indices/base.ts 0% <ø> (ø) ⬆️
.../processor/handlers/verification-failed-handler.ts 100% <ø> (ø) ⬆️
.../src/repositories/delegates-business-repository.ts 84.21% <ø> (ø) ⬆️
packages/core-container/src/config/schema.ts 100% <ø> (ø) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edeebd3...796926e. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review Apr 14, 2019

@faustbrian faustbrian merged commit 7f5b808 into 2.4 Apr 14, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.