Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace bignumify with Utils.BigNumber.make #2416

Merged
merged 7 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 14, 2019

Proposed changes

Get rid of the bignumify helper in core-utils.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 14, 2019

The ci/circleci: test-node10-unit job is failing as of 0f08bcba124b7d89ed70cb5788ccf45249beeff2. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits Apr 14, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #2416 into 2.4 will not change coverage.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4    #2416   +/-   ##
=======================================
  Coverage   68.29%   68.29%           
=======================================
  Files         402      401    -1     
  Lines        8615     8615           
  Branches      433      392   -41     
=======================================
  Hits         5884     5884           
- Misses       2685     2687    +2     
+ Partials       46       44    -2
Impacted Files Coverage Δ
packages/core-forger/src/delegate.ts 100% <ø> (ø) ⬆️
packages/crypto/src/crypto/crypto.ts 95.74% <ø> (ø) ⬆️
packages/core-tester-cli/src/commands/command.ts 60% <0%> (-0.61%) ⬇️
packages/core-database/src/wallet-manager.ts 73.54% <0%> (ø) ⬆️
...s/core-database-postgres/src/integrity-verifier.ts 6.17% <0%> (ø) ⬆️
packages/core-database/src/database-service.ts 27.48% <0%> (ø) ⬆️
...s/core-transaction-pool/src/dynamic-fee/matcher.ts 97.14% <100%> (ø) ⬆️
...actions/builders/transactions/timelock-transfer.ts 66.66% <100%> (ø) ⬆️
packages/crypto/src/blocks/deserializer.ts 92.72% <100%> (ø) ⬆️
packages/crypto/src/utils/bignum.ts 100% <100%> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5b808...0c60e7b. Read the comment docs.

@faustbrian faustbrian merged commit c50a7fc into 2.4 Apr 14, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/bignumify branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.