Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): remove extraneous Client class #2417

Merged
merged 2 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 14, 2019

Proposed changes

Remove the extraneous Client class which serves no real purpose as everything is accessible via imports.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 14, 2019

The ci/circleci: test-node11-unit job is failing as of 6592973f3f32b3ced7ee7702bcb53e9052888e63. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #2417 into 2.4 will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2417      +/-   ##
==========================================
- Coverage   68.29%   68.24%   -0.06%     
==========================================
  Files         401      400       -1     
  Lines        8615     8600      -15     
  Branches      432      391      -41     
==========================================
- Hits         5884     5869      -15     
- Misses       2686     2687       +1     
+ Partials       45       44       -1
Impacted Files Coverage Δ
packages/crypto/src/managers/config.ts 98.03% <ø> (ø) ⬆️
packages/crypto/src/identities/keys.ts 100% <100%> (ø) ⬆️
packages/core-tester-cli/src/signer.ts 87.5% <100%> (-0.74%) ⬇️
packages/core-logger-winston/src/formatter.ts 46.15% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50a7fc...d05da32. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review Apr 14, 2019

@faustbrian faustbrian merged commit 097f051 into 2.4 Apr 14, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/crypto-client branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.