Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): add more type hints #2418

Merged
merged 2 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 14, 2019

Proposed changes

Adds more type hints to @arkecosystem/crypto and hints interfaces instead of concretes.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 14, 2019

Codecov Report

Merging #2418 into 2.4 will decrease coverage by 0.06%.
The diff coverage is 83.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2418      +/-   ##
==========================================
- Coverage   68.24%   68.17%   -0.07%     
==========================================
  Files         400      400              
  Lines        8600     8592       -8     
  Branches      391      393       +2     
==========================================
- Hits         5869     5858      -11     
  Misses       2687     2687              
- Partials       44       47       +3
Impacted Files Coverage Δ
packages/crypto/src/managers/network.ts 100% <ø> (ø) ⬆️
packages/crypto/src/crypto/hash-algorithms.ts 100% <ø> (ø) ⬆️
...ions/builders/transactions/delegate-resignation.ts 73.33% <0%> (ø) ⬆️
...s/crypto/src/transactions/types/multi-signature.ts 29.16% <0%> (ø) ⬆️
...actions/builders/transactions/timelock-transfer.ts 66.66% <0%> (ø) ⬆️
...ges/crypto/src/transactions/types/multi-payment.ts 39.13% <0%> (ø) ⬆️
...pto/src/transactions/builders/transactions/ipfs.ts 72% <0%> (ø) ⬆️
packages/crypto/src/transactions/types/ipfs.ts 46.66% <0%> (ø) ⬆️
...crypto/src/transactions/types/timelock-transfer.ts 42.85% <0%> (ø) ⬆️
...kages/crypto/src/transactions/types/transaction.ts 84.74% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097f051...e4fcac9. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review Apr 14, 2019

@faustbrian faustbrian merged commit 7ca542b into 2.4 Apr 14, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/crypto-hints branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.