Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add types, remove dead code and unused imports #2420

Merged
merged 9 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 15, 2019

Proposed changes

  • Add more type hints
  • Add more return types
  • Add more interfaces
  • Remove dead code
  • Remove unused imports
  • Reduce complexity of a few classes
  • Ensure satoshi values are stored as strings in files

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 15, 2019

The ci/circleci: test-node10-integration-0 job is failing as of a2e37bbacd41332109cb38ee30346f23b253523b. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #2420 into 2.4 will decrease coverage by 1.86%.
The diff coverage is 80.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2420      +/-   ##
==========================================
- Coverage   68.17%   66.31%   -1.87%     
==========================================
  Files         400      398       -2     
  Lines        8592     8565      -27     
  Branches      433      432       -1     
==========================================
- Hits         5858     5680     -178     
- Misses       2686     2838     +152     
+ Partials       48       47       -1
Impacted Files Coverage Δ
...kages/core-api/src/versions/2/peers/transformer.ts 66.66% <ø> (-13.34%) ⬇️
packages/core/src/commands/snapshot/rollback.ts 0% <ø> (ø) ⬆️
packages/core-api/src/versions/1/utils.ts 92.3% <ø> (ø) ⬆️
packages/core-transaction-pool/src/utils.ts 0% <ø> (ø) ⬆️
packages/crypto/src/crypto/crypto.ts 90.69% <ø> (ø) ⬆️
packages/core/src/commands/config/publish.ts 0% <ø> (ø) ⬆️
packages/core-api/src/versions/2/rounds/schema.ts 100% <ø> (ø) ⬆️
...ackages/core-transactions/src/handlers/transfer.ts 66.66% <ø> (ø) ⬆️
...kages/core-api/src/versions/1/peers/transformer.ts 100% <ø> (ø) ⬆️
...kages/core-api/src/versions/2/delegates/methods.ts 89.65% <ø> (ø) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca542b...8091ae3. Read the comment docs.

faustbrian added some commits Apr 15, 2019

@faustbrian faustbrian marked this pull request as ready for review Apr 15, 2019

@faustbrian faustbrian merged commit 7b5ea48 into 2.4 Apr 15, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/more-types branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.