Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-json-rpc): reduce complexity and add types #2422

Merged
merged 4 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 15, 2019

Proposed changes

Add types to core-json-rpc and reduce complexity & nesting.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 15, 2019

The ci/circleci: test-node11-unit job is failing as of 9e8f15d9a66934315602c4b8b8dd2b068e737fea. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian marked this pull request as ready for review Apr 15, 2019

@faustbrian faustbrian merged commit 60e3b06 into 2.4 Apr 15, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/json-rpc branch Apr 15, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #2422 into 2.4 will increase coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2422      +/-   ##
==========================================
+ Coverage   66.34%   66.58%   +0.23%     
==========================================
  Files         398      388      -10     
  Lines        8540     8510      -30     
  Branches      396      434      +38     
==========================================
  Hits         5666     5666              
+ Misses       2828     2797      -31     
- Partials       46       47       +1
Impacted Files Coverage Δ
...ages/core-json-rpc/src/server/services/database.ts 0% <0%> (ø) ⬆️
...s/core-json-rpc/src/server/modules/transactions.ts 0% <0%> (ø)
...ges/core-json-rpc/src/server/services/processor.ts 0% <0%> (ø) ⬆️
packages/core-json-rpc/src/server/utils.ts 0% <0%> (ø)
...ckages/core-json-rpc/src/server/modules/wallets.ts 0% <0%> (ø)
...ackages/core-json-rpc/src/server/modules/blocks.ts 0% <0%> (ø)
...kages/core-json-rpc/src/server/services/network.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddce7a...e669a12. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.