Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-webhooks): drop no longer needed pagination #2424

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Collaborator

faustbrian commented Apr 15, 2019

Proposed changes

Drop the pagination from core-webhooks as it is not needed for as small blobs of data as the webhooks are.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

faustbrian added some commits Apr 15, 2019

fix
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Apr 15, 2019

The ci/circleci: test-node10-unit job is failing as of 21dcf82f1b2cd21a41adafaed0fab4e790062f90. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #2424 into 2.4 will increase coverage by 0.13%.
The diff coverage is 14.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2424      +/-   ##
==========================================
+ Coverage   66.58%   66.71%   +0.13%     
==========================================
  Files         388      386       -2     
  Lines        8510     8484      -26     
  Branches      434      434              
==========================================
- Hits         5666     5660       -6     
+ Misses       2797     2777      -20     
  Partials       47       47
Impacted Files Coverage Δ
packages/core-json-rpc/src/server/modules.ts 0% <0%> (ø)
packages/core-webhooks/src/listener.ts 0% <0%> (ø) ⬆️
packages/core-webhooks/src/server/schema.ts 100% <100%> (ø) ⬆️
packages/core-webhooks/src/database.ts 100% <100%> (ø) ⬆️
packages/core-webhooks/src/server/utils.ts 100% <100%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e3b06...21dcf82. Read the comment docs.

@faustbrian faustbrian merged commit 886b4a8 into 2.4 Apr 15, 2019

8 checks passed

ci/circleci: test-node10-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node10-unit Your tests passed on CircleCI!
Details
ci/circleci: test-node11-functional Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-0 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-integration-1 Your tests passed on CircleCI!
Details
ci/circleci: test-node11-unit Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/webhooks-pagi branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.