Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): don't swallow errors in buildWallets #2428

Merged
merged 2 commits into from Apr 16, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Apr 16, 2019

Proposed changes

Errors in buildWallets were swallowed which meant the state machine would never be able to catch any issues with it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Apr 16, 2019

The ci/circleci: test-node10-unit job is failing as of eb2150f7c945a0274d5abf7a4695bf8cf4c3a123. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ghost
Copy link

ghost commented Apr 16, 2019

The ci/circleci: test-node10-unit job is failing as of 2b0295614e29856a830c51ecbbdc84568a193da7. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #2428 into 2.4 will increase coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              2.4   #2428      +/-   ##
=========================================
+ Coverage   67.92%     68%   +0.08%     
=========================================
  Files         385     385              
  Lines        8443    8433      -10     
  Branches      392     392              
=========================================
  Hits         5735    5735              
+ Misses       2660    2650      -10     
  Partials       48      48
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 27.61% <0%> (+0.13%) ⬆️
.../core-database-postgres/src/postgres-connection.ts 59.61% <0%> (+1.67%) ⬆️
...s/core-database-postgres/src/integrity-verifier.ts 6.66% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92adfad...e9833f0. Read the comment docs.

@faustbrian faustbrian merged commit 18a5d4f into 2.4 Apr 16, 2019
@ghost ghost deleted the fix/db-build-wallets branch April 16, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants